TST Replace assert_raises* by pytest.raises in model_selection/tests/test_validation.py #19381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#DataUmbrella sprint |
thomasjpfan
approved these changes
Feb 6, 2021
lorentzenchr
reviewed
Feb 6, 2021
|
@cycks We forgot to add in the original issue the |
|
@glemaitre I am working on it right now I will submit a pr once I am done. |
As @glemaitre said in #19432, please push your commit to the branch of this current PR instead to finalize it. |
|
I'm working at completing this PR. Due to lack of permissions to push to this PR branch, a new branch starting from this PR branch is created. #19592 is the new corresponding PR. |
|
Continued in #19592. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #14216
What does this implement/fix? Explain your changes.
replace assert_raises* by pytest.raise in model_selection/tests/test_validation.py
Any other comments?
cc: (pair programming partner) @mohaseeb