[DEBUG] TST check sparse dense equivalence in KMeans #19403
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremiedbb mentioned that it could be due to two initialization providing close results and that could be inter-exchange due to precision error depending on the system. |
|
Maybe we could select a better run only if its inertia is smaller than the current best by more than some scikit-learn/sklearn/cluster/_kmeans.py Line 1030 in 7e197fd something like |
|
@jeremiedbb that sounds like a good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be an example where dense is not equivalent to sparse.
Related to an issue found in imbalanced-learn: scikit-learn-contrib/imbalanced-learn#788