Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX Gives a unique id to html visualization #19417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2021
Merged

FIX Gives a unique id to html visualization #19417

merged 4 commits into from
Feb 15, 2021

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

The CSS is now targeted to a specific container by ID, which helps isolated the CSS from other elements. Using an ID increases the specificity of the selector which gives the style in scikit-learn higher precedence.

What does this implement/fix? Explain your changes.

This resolves the issue here: INRIA/scikit-learn-mooc#146

Screen Shot 2021-02-09 at 1 56 08 PM

CC @lesteve

@thomasjpfan thomasjpfan added this to the 0.24.2 milestone Feb 9, 2021
@thomasjpfan
Copy link
Member Author

Milestone this for 0.24.2 for now, open to have it moved to 1.0.

@thomasjpfan thomasjpfan marked this pull request as draft February 9, 2021 19:22
@thomasjpfan thomasjpfan marked this pull request as ready for review February 9, 2021 20:41
glemaitre
glemaitre approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this change. @lesteve do you want to have a look at it

@lesteve
Copy link
Member

lesteve commented Feb 11, 2021

This looks good to me (full disclosure: I didn't know you can have nested style inside a div).

Just to be sure, I'll double check this fixes the problem in the MOOC and merge if this is the case.

@lesteve
Copy link
Member

lesteve commented Feb 11, 2021

I doubled-check and indeed this fixes it on the MOOC side, thanks a lot!

About including this in the 0.24.2 release this would be more convenient for the MOOC. The change seems innocuous enough but at the same time it is not a horrible bug that absolutely needs to be fixed in 0.24.2.

Since I am not involved in the day-to-day scikit-learn maintenance I am probably not the best person to decide so I'll let this one open for now ...

@lesteve
Copy link
Member

lesteve commented Feb 15, 2021

OK I am going to merge this one!

Nobody complained and I have heard that 0.24.2 is not going to be a super quick bugfix-only release.

@lesteve lesteve merged commit b251f3f into scikit-learn:main Feb 15, 2021
@lesteve lesteve mentioned this pull request Feb 16, 2021
Closed
@cmarmo cmarmo added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Apr 6, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@thomasjpfan @glemaitre
FIX Gives a unique id to html visualization (scikit-learn#19417)
3986907
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
@thomasjpfan @glemaitre
FIX Gives a unique id to html visualization (#19417)
26167b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:utils To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
0.24.2
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @lesteve @glemaitre @cmarmo