-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
ENH Add kwargs to format ICE and PD lines separately in partial dependence plots #19428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
f8ca2fd
Add parameters to format ICE and PD lines separately in partial depen…
mhham 3b71e0d
Add warning when line_kw is used in conjunction with pd_line_kw or ic…
mhham e35187d
Add test to check line formatting behavior in partial dependence plot
mhham 69c33fe
Add PR info to whats_new
mhham 6a21afa
Add call to action to silence line_kw warning
mhham b2b5d74
Add comment to explain what test does
mhham 41ede4d
Add partial dependence line kwargs to documentation
mhham 281ad24
Add line_kw ice_lines_kw pd_line_kw warnings test
mhham 8ff4183
Formatting + pytest check UserWarning instead of Warning
mhham 0e6001a
Merge branch 'main' into feature/pdp-ice-pd-lines
mhham c01307d
Apply suggestions from code review: versionadded
mhham 6c2d85f
Add ICE and PDP line formatting to example
mhham 61cca2e
Merge remote-tracking branch 'upstream/main' into feature/pdp-ice-pd-…
mhham 7839d7e
Merge remote-tracking branch 'origin/main' into pr/mhham/19428
glemaitre 438b685
fix whats new
glemaitre 91f7acf
Apply suggestions from code review
glemaitre bca4719
black
glemaitre 2db0eb1
solve issue warning
glemaitre 724ef4b
Merge remote-tracking branch 'origin/main' into pr/mhham/19428
glemaitre 17cf123
TST check that we don't raise spurious warnings
glemaitre 739f3f9
avoid warning
glemaitre 4a012c5
improve doc
glemaitre a8c3597
Merge remote-tracking branch 'origin/main' into pr/mhham/19428
glemaitre c45c98d
Apply suggestions from code review
glemaitre 5d9c8a0
Merge remote-tracking branch 'origin/main' into pr/mhham/19428
glemaitre 15a4288
Update plot_partial_dependence.py
glemaitre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.