DOC Fix overlapping titles in clustering overview #19506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Feb 20, 2021
thomasjpfan
approved these changes
Feb 21, 2021
There was a problem hiding this comment.
LGTM! I think this is an improvement over main. Thank you for working on this @putschblos !
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
The comparison plot for the clustering overview contains overlapping titles.
What does this implement/fix? Explain your changes.
I just split the long titles into to lines via '\n'. And slightly decreased the text size of the titles.
Any other comments?
The problem was mentioned in #9739.
I am not sure if you guys still want to rework the overview by transposing them.
If you are not happy with my solution just let me know.