Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST replace assert_raise with pytest.raises in calibration, check_build, metaestimators #19509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2021
Merged

TST replace assert_raise with pytest.raises in calibration, check_build, metaestimators #19509

merged 1 commit into from
Mar 1, 2021

Conversation

azihna
Copy link
Contributor

@azihna azihna commented Feb 20, 2021

Reference Issues/PRs

References #14216

What does this implement/fix? Explain your changes.

Changes the assert_raises to pytest.raises(...) for the smaller files with fewer changes in a single PR. Following files are affected:

  • test_calibration
  • test_check_build
  • test_metaestimators

Any other comments?

#DataUmbrella

ogrisel
ogrisel approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogrisel ogrisel merged commit c00c4bd into scikit-learn:main Mar 1, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azihna @ogrisel