CI Fixes twitter workflow #19525
Merged
CI Fixes twitter workflow #19525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Feb 22, 2021
|
Submitted a PR to the repo here: xorilog/twitter-action#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19524
The original failure was caused by golang going to 1.16, which changes the way it works with go modules. I migrate the
twitter-actionto use go modules: thomasjpfan/twitter-action@c308e44 (go modules uses hashing to pin dependencies)Also this PR points to my build on dockerhub, which means our CI would not need to build it everytime.