Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT Clear travis installation script #19532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

MNT Clear travis installation script #19532

merged 1 commit into from
Feb 25, 2021

Conversation

alfaro96
Copy link
Member

What does this implement/fix? Explain your changes.

This PR removes the if statement to use a different Miniconda URL for ARM64 architectures. Currently, travis only uses ARM64 architectures.

thomasjpfan
thomasjpfan approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rth
rth approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rth rth merged commit 15d2df4 into scikit-learn:main Feb 25, 2021
@alfaro96 alfaro96 deleted the clear_travis_job branch March 1, 2021 08:56
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@alfaro96 @glemaitre
MNT Clear travis installation script (scikit-learn#19532)
2914a0b
glemaitre pushed a commit that referenced this pull request Apr 28, 2021
@alfaro96 @glemaitre
MNT Clear travis installation script (#19532)
6e2f1e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfaro96 @rth @thomasjpfan