TST Change assert from sklearn to pytest style in tests/test_discriminant.py #19558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Feb 25, 2021
|
Note: I edited the title to make it more explicit about which module is impacted when scanning though the discussion history of #14216. |
ogrisel
reviewed
Feb 27, 2021
ogrisel
reviewed
Mar 1, 2021
ogrisel
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Ok I investigated #19558 (review) and found that the runtime warning (divide by zero) was always raised at predict time only (for the unregularized case) while the fit method only raises the UserWarning.
I reorganized the checks accordingly.
I think this highlights suboptimal warning behavior of this class. I will open a dedicated issue. Fixing this can be done in a subsequent PR to keep the scope of this PR focused on the original problem.
|
Thanks @ogrisel |
rth
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Reference #14216
What does this implement/fix? Explain your changes.
Changed the assert_raises, assert_message, assert_warns in tests/test_discriminant.py to pytest.raises() and pytest.warns.
Changed ignore_warnings to @pytest.mark.filterwarnings() because each assert in the test was encapsulated in ignore_warnings context.