FIX race condition in get_data_home causing FileExistsError #19560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
Feb 25, 2021
|
I merged this because it might also be the cause of other random failures such as #19587. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 22, 2021
glemaitre
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's safer to use
os.makedirs(..., exists_ok=True)now that we don't have to support Python 2 anymore.This should avoid spurious failures when running the tests with
pytest-xdist:https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=26901&view=logs&j=e6d5b7c0-0dfd-5ddf-13d5-c71bebf56ce2&t=c500742d-7cbe-569e-8da5-94db9b4cd21e&l=445
I don't think this change requires additional tests or a changelog entry. Let me know if you disagree.