eliminate performance regression when normalize is False #19606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19600
There was a major performance regression in the linear models. This was due to the new use of the
_incremental_mean_and_var().In the case when
normalizeparameter is not set in the linear model calculations of the variance are not necessary. This PR exchanges it fornp.average()in case whennormalizeis set to False.Performance (current main):
zoomed into
_preprocess_dataat_base.py:Performance (this PR):
zoomed into
_preprocess_dataat_base.py:The performance is measured using the code of @jeremiedbb :
cc @ogrisel @jeremiedbb @agramfort