TST Replace assert_warns in covariance/tests #19757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
approved these changes
Mar 23, 2021
jeremiedbb
reviewed
Mar 23, 2021
doc/whats_new/v1.0.rst
Outdated
Comment on lines
210
to
215
| :mod:`sklearn.covariance.tests` | ||
| ................... | ||
|
|
||
| - |Enhancement| Replace the use of assert_warns and assert_warns_message | ||
| with the pytest context manager. :pr:`19757` by :user:`Isaack Mungui <isaack-mungui>`. | ||
|
|
There was a problem hiding this comment.
No change log entry is needed for this PR. I added the no change log needed tag
There was a problem hiding this comment.
I've reverted the commit.
This reverts commit ec6b3d0.
lorentzenchr
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #19414
What does this implement/fix? Explain your changes.
Replaces assert_warns and assert_warns_message with the python context manager