MAINT Improve Nearest Neighbor documentation + code consistency #19793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Fix typos 2) Use self.metric == "precomputed" instead of combination of both self.effective_metric and self.metric 3) Use n_samples_fit instead of a combination of both n_indexed and n_samples_fit 4) Other minor changes
thomasjpfan
reviewed
Apr 3, 2021
There was a problem hiding this comment.
I think most of the code changes are an improvement.
For the documentation changes, we do use n_indexed in other places, such as check_pairwise_arrays. To move forward, I suggest reverting the docstring changes relating to n_indexed and opening another PR for n_indexed.
In general, keeping PRs smaller makes them easier to merge.
|
@thomasjpfan Per your instructions, I've reverted the relevant changes. |
thomasjpfan
approved these changes
Apr 4, 2021
TomDLT
approved these changes
Apr 5, 2021
|
Thanks @chrisyeh96 ! |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos
Use
self.metric == "precomputed"instead of combination of bothself.effective_metricandself.metric. (self.effective_metricis only different fromself.metriconly for minkowski metric. For"precomputed"metric,self.effective_metricandself.metricare equivalent.)Usen_samples_fitinstead of a combination of bothn_indexedandn_samples_fitOther minor changes