MNT remove deprecation of least_squares in HGBT #19976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Decision from dev meeting April 2021 26th: We prefer the usual deprecation cycle together with all the other models that are effected by this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Possible follow-up on #19310 and #19799.
What does this implement/fix? Explain your changes.
#19310 deprecated the use of
"least_squares"inHistGradientBoostingRegressorand #19799 took HGBT out of experimental. As it still is experimental until the release, we don't need the usual deprecation cycle on changes.Any other comments?
This is for discussion. A decision to keep the deprecation and not merge this PR is fine as well.