Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mlondschien
Copy link
Contributor

Closes #19598.

@mlondschien
Copy link
Contributor Author

Does this warrant a changelog entry @lorentzenchr?

@lorentzenchr
Copy link
Member

Does this warrant a changelog entry @lorentzenchr?

I don't think so.
The docstring of n_knots should reflect this slight change.

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorentzenchr
Copy link
Member

CI failure is unrelated (time-out).

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion for further improvement. Otherwise I am ok with the proposed change.

@ogrisel ogrisel merged commit 7781256 into scikit-learn:main Jun 7, 2021
@mlondschien mlondschien deleted the issue-19598 branch June 7, 2021 15:11
thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Jun 8, 2021
* TST enable test docstring params for feature extraction module (scikit-learn#20188)

* DOC fix a reference in sklearn.ensemble.GradientBoostingRegressor (scikit-learn#20198)

* FIX mcc zero divsion  (scikit-learn#19977)

* TST Add TransformedTargetRegressor to test_meta_estimators_delegate_data_validation (scikit-learn#20175)

Co-authored-by: Guillaume Lemaitre <[email protected]>

* TST enable n_feature_in_ test for feature_extraction module

* FIX Uses points instead of pixels in plot_tree (scikit-learn#20023)

* MNT n_features_in through the multiclass module (scikit-learn#20193)

* CI Removes python 3.6 builds from wheel building (scikit-learn#20184)

* FIX Fix typo in error message in `fetch_openml` (scikit-learn#20201)

* FIX Fix error when using Calibrated with Voting (scikit-learn#20087)

* FIX Fix RandomForestRegressor doesn't accept max_samples=1.0 (scikit-learn#20159)

Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>

* ENH Adds Poisson criterion in RandomForestRegressor (scikit-learn#19836)

Co-authored-by: Christian Lorentzen <[email protected]>
Co-authored-by: Alihan Zihna <[email protected]>
Co-authored-by: Alihan Zihna <[email protected]>
Co-authored-by: Chiara Marmo <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: naozin555 <[email protected]>
Co-authored-by: Venkatachalam N <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>

* TST Replace assert_warns from decomposition/tests (scikit-learn#20214)

* TST check n_features_in_ in pipeline module (scikit-learn#20192)

Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>

* Allow `n_knots=None` if knots are explicitly specified in `SplineTransformer` (scikit-learn#20191)


Co-authored-by: Olivier Grisel <[email protected]>

* FIX make check_complex_data deterministic (scikit-learn#20221)

* TST test_fit_docstring_attributes include properties (scikit-learn#20190)

* FIX Uses the color max for colormap in ConfusionMatrixDisplay (scikit-learn#19784)

* STY Changing .format method to f-string formatting (scikit-learn#20215)

* CI Adds permissions for label action

Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: tsuga <[email protected]>
Co-authored-by: Conner Shen <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: mlondschien <[email protected]>
Co-authored-by: Clément Fauchereau <[email protected]>
Co-authored-by: murata-yu <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Brian Sun <[email protected]>
Co-authored-by: Christian Lorentzen <[email protected]>
Co-authored-by: Alihan Zihna <[email protected]>
Co-authored-by: Alihan Zihna <[email protected]>
Co-authored-by: Chiara Marmo <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: naozin555 <[email protected]>
Co-authored-by: Venkatachalam N <[email protected]>
Co-authored-by: Nanshan Li <[email protected]>
Co-authored-by: solosilence <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SplineTransformer raises when passing knots explicity for n_knots=None
3 participants