TST make sure to test SearchCV on both classification and regression #20202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
That should yield 8 test cases instead of 4 previously? I think this is fine.
Alternatively one could have just swapped Ridge and LogisticRegression to keep 4 cases but ensured that to have:
- GS + Ridge
- RS + LR
- GS + pipeline(PCA + LR)
- RS + pipeline(PCA + Ridge)
with a comment to explain that this would offers tradeoff exhaustive of the combinations with test speed.
This way we have test for GS and RS both in regression and classification problem, both with and without pipelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use the product of the
SearchCV, classifier, and regressor instead of azip.I don't think that I intended the current behaviour when creating the test.