Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

rhythmchanges
Copy link
Contributor

@rhythmchanges rhythmchanges commented Jun 26, 2021

Reference Issues/PRs

Addresses #20308

What does this implement/fix? Explain your changes.

This PR ensures KMeans is compatible with numpydocd

  • Remove KMeans from DOCSTRING_IGNORE_LIST
  • Verify all tests passing.

Any other comments?

Thanks #DataUmbrellla
CC @pibieta @g4brielvs (pair programming 2021 Latin America scikit-learn open source sprint)

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are passing locally. Let's wait for the CIs to agree and we can merge.

@rhythmchanges
Copy link
Contributor Author

rhythmchanges commented Jun 26, 2021

@glemaitre Thank you for taking the time to review my PR!

@glemaitre glemaitre merged commit 2645eb3 into scikit-learn:main Jun 26, 2021
@glemaitre
Copy link
Member

Thanks @g4brielvs

@reshamas
Copy link
Member

Updating with correct spelling: #DataUmbrella sprint

ogrisel added a commit that referenced this pull request Jun 29, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants