Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

trhughes
Copy link

@trhughes trhughes commented Jun 26, 2021

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Changed order of sections in KneighborsRegressor class at sklearn/neighbors/_regression.py.

Any other comments?

This is part of the following issue: "Ensure that docstrings pass numpydoc validation" #20308

@trhughes trhughes marked this pull request as draft June 26, 2021 18:18
@reshamas
Copy link
Member

#DataUmbrella sprint

@thomasjpfan thomasjpfan marked this pull request as ready for review June 26, 2021 19:55
@thomasjpfan thomasjpfan marked this pull request as draft June 26, 2021 19:55
@thomasjpfan
Copy link
Member

Feel free to make this "ready for review" when you are ready.

@trhughes trhughes changed the title First fix to KneighborsRegressor docstring DOC Ensures that KNeighborsRegressor passes numpydoc validation Jun 26, 2021
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @trhughes ! Did you keep it in Draft mode because you wanted to add more things?

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @trhughes !

@trhughes trhughes marked this pull request as ready for review July 9, 2021 04:26
Co-authored-by: Cristián Maureira-Fredes <[email protected]>
@glemaitre glemaitre self-assigned this Jul 20, 2021
@glemaitre glemaitre changed the title DOC Ensures that KNeighborsRegressor passes numpydoc validation DOC Ensures that K/RadiusNeighborsRegressor passes numpydoc validation Jul 20, 2021
@glemaitre
Copy link
Member

I solve the issue normally. Let see if the CIs are happy.

@glemaitre glemaitre merged commit 2480f5a into scikit-learn:main Jul 20, 2021
@glemaitre
Copy link
Member

Thanks @trhughes

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
scikit-learn#20378)

Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Cristián Maureira-Fredes <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants