Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

genvalen
Copy link
Contributor

@genvalen genvalen commented Jun 30, 2021

Reference Issues/PRs

Addresses #20308
#dataumbrella sprint
cc: @j3nnn1

What does this implement/fix? Explain your changes.

Added more NB classes to the "See Also" section of BernoulliNB.
Edit: Fixed errors to help file pass numpydoc validation

Any other comments?

genvalen and others added 30 commits June 6, 2020 16:02
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
@genvalen genvalen changed the title [WIP] DOC Ensures that BernoulliNB passes numpydoc validation DOC Ensures that BernoulliNB passes numpydoc validation Jun 30, 2021
@genvalen genvalen marked this pull request as ready for review June 30, 2021 13:51
@genvalen genvalen marked this pull request as draft June 30, 2021 14:25
@genvalen genvalen marked this pull request as ready for review June 30, 2021 14:32
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the trailing space clean-up will make the CI linter pass, here are few other suggestions but other than that LGTM!

genvalen and others added 3 commits June 30, 2021 13:28
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
@genvalen
Copy link
Contributor Author

Assuming the trailing space clean-up will make the CI linter pass, here are few other suggestions but other than that LGTM!

I accepted the changes. Thanks for reviewing this PR and the last!

@genvalen genvalen closed this Jun 30, 2021
@genvalen genvalen deleted the bernouliNB_numpy_doc branch June 30, 2021 20:03
@genvalen genvalen restored the bernouliNB_numpy_doc branch June 30, 2021 20:06
@genvalen genvalen deleted the bernouliNB_numpy_doc branch June 30, 2021 20:14
@genvalen genvalen restored the bernouliNB_numpy_doc branch June 30, 2021 23:05
@genvalen genvalen reopened this Jun 30, 2021
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @genvalen !

REF: #20308 (comment)

genvalen and others added 3 commits June 30, 2021 20:42
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
@thomasjpfan thomasjpfan merged commit e4ef854 into scikit-learn:main Jul 1, 2021
@genvalen genvalen deleted the bernouliNB_numpy_doc branch July 1, 2021 02:34
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…#20429)

Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Adrin Jalali <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants