MNT use check_scalar to validate scalar in AffinityPropagation #20723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Aug 12, 2021
sklearn/utils/validation.py
Outdated
| target_type, | ||
| *, | ||
| min_val=None, | ||
| strictly_greater_min_val=False, |
There was a problem hiding this comment.
would it not make sense to have a {min, max}_is_inclusive parameter instead?
ogrisel
approved these changes
Aug 12, 2021
Co-authored-by: Olivier Grisel <[email protected]>
3 tasks
jjerphan
reviewed
Aug 30, 2021
adrinjalali
approved these changes
Aug 31, 2021
This was referenced Oct 18, 2021
2 tasks
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…t-learn#20723) * MNT use check_scalar to validate scalar in AffinityPropagation * refactor * Apply suggestions from code review Co-authored-by: Olivier Grisel <[email protected]> * iter * iter * iter * iter * iter Co-authored-by: Olivier Grisel <[email protected]>
2 tasks
41 tasks
2 tasks
This was referenced Dec 10, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #20724
Example for using
check_scalarin parameters validation in estimator class.