-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MRG allow empty grid in ParameterGrid #2082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Demo:
That's exactly the default settings for
|
Hmm. While I've had a case that would benefit from this (only because the extension of ParameterGrid to handle lists of grids, together with #1769), I think this is a bit unintuitive. Is it better to use |
IMHO, it hardly changes the semantics. A grid like |
I see your point. The number of candidates is less intuitive, but if from In any case, please add documentation and fix/test for |
And please refer to it as a "special case" rather than a "corner case", even if you find it an intuitive special case. |
There. I added a commit that finally explains the behavior of ParameterGrid on lists. |
Ping @mblondel. |
I think this comment could also be removed: Other than that, LGTM |
I figured it would be smart to explain what the example does, but I can remove it. |
Thanks to @mblondel for explaining this functionality.
MRG allow empty grid in ParameterGrid
Fixes #2048.