API Deprecate n_features_in_ from Dummy*
#20960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n_features_in_ from Dummy* n_features_in_ from Dummy*
|
Ups my approval was a bit too fast. We need to update the tests to avoid raising the warning. I think that for some tests, we might need to change the |
|
Whops, @NicolasHug was a bit too fast :). I will make a PR to correct the failures then :) |
|
Oh wow, sorry... I was sure I checked 🤦 |
|
I opened #20963 |
adrinjalali
pushed a commit
that referenced
this pull request
Sep 7, 2021
|
This one needs to be backported |
|
done already |
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Sep 7, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #20874
What does this implement/fix? Explain your changes.
An alternative is to define
n_features_in_andfeature_names_in_and not validate.CC @NicolasHug