Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH add pos_label to CalibrationDisplay #21038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Oct 27, 2021

Conversation

glemaitre
Copy link
Member

Follow up to #21032 adding pos_label to CalibrationDisplay

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Just some some minor suggestions.

@glemaitre
Copy link
Member Author

Maybe @thomasjpfan has some time to look at this one. @lucyleeow might also be interested.

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some tiny suggestions.

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks @glemaitre !

@jeremiedbb jeremiedbb merged commit 90bef46 into scikit-learn:main Oct 27, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants