Addresses #20308 LabelPropagation #21223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion but one test still fails
|
@ovynnej to fix that you have to add the descriptions of the return value. For example something like this could work: """
Returns
-------
self : object
Fitted estimator.
"""Nevertheless, there was another person working on the same estimator (PR) that is waiting for review. Maybe you didn't see the message in the issue because there are too many comments there. Try to choose a different estimator if you can. |
|
@jmloyola thank you for your helpful feedback and explanation. I will pick a different estimator and check more carefully that it isn't redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308.
What does this implement/fix? Explain your changes.
I made fixes to the docstrings in _label_propagation.py, but one test might still be failling.
Any other comments?
Running
python3 -m numpydoc sklearn.semi_supervised.LabelPropagation --validategave me three errors before my fixes and no errors now.Running
pytest maint_tools/test_docstrings.py -k LabelPropagation-gave me many errors before my fixes and now gives me one error:RT03: Return value has no description.This seems to be the problem:
I tried changing
self : object(which is at lines 261 and 486) to the following things:self : object.self : The return value is the object....because I thought maybe it wanted a period at the end, or a longer statement, but I got the same error whenever I ran
pytest maint_tools/test_docstrings.py -k LabelPropagation-again.I'd be grateful for help!