DOC Ensures that SpectralCoclustering passes numpydoc validation #21282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunal-05
pushed a commit
to kunal-05/scikit-learn
that referenced
this pull request
Oct 20, 2021
kunal-05
pushed a commit
to kunal-05/scikit-learn
that referenced
this pull request
Oct 20, 2021
kunal-05
pushed a commit
to kunal-05/scikit-learn
that referenced
this pull request
Oct 21, 2021
glemaitre
reviewed
Oct 21, 2021
Comment on lines
+302
to
+304
| SpectralClustering: Performs a low-dimension embedding of the | ||
| affinity matrix between samples, followed by clustering, e.g., by KMeans, | ||
| of the components of the eigenvectors in the low dimensional space. |
There was a problem hiding this comment.
I am not able to make suggestions. I assume that when opening the PR, you unchecked the checkbox that allows maintainers to make some editing.
Here, you should replace with:
SpectralClustering : Apply clustering to a projection of the normalized Laplacian.| Returns | ||
| ------- | ||
| self: object |
| Returns | ||
| ------- | ||
| self: object | ||
| Fitted biclustering for X. |
There was a problem hiding this comment.
Replace with
Returns a fitted instance.| Training instances to cluster. | ||
| y : Ignored | ||
| Not used. |
There was a problem hiding this comment.
Replace with
y : Ignored
Not used, present for API consistency by convention.
kunal-05
pushed a commit
to kunal-05/scikit-learn
that referenced
this pull request
Oct 21, 2021
kunal-05
pushed a commit
to kunal-05/scikit-learn
that referenced
this pull request
Oct 21, 2021
kunal-05
pushed a commit
to kunal-05/scikit-learn
that referenced
this pull request
Oct 21, 2021
kunal-05
pushed a commit
to kunal-05/scikit-learn
that referenced
this pull request
Oct 21, 2021
kunal-05
pushed a commit
to kunal-05/scikit-learn
that referenced
this pull request
Oct 21, 2021
kunal-05
pushed a commit
to kunal-05/scikit-learn
that referenced
this pull request
Oct 21, 2021
|
Addressed in #21463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
Any other comments?