MNT Add validation of scalar parameters in Ridge #21341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 19, 2021 13:42
Also corrects validation for alpha
525b117 to
88a2244
Compare
d4112e0 to
fe56c15
Compare
jjerphan
reviewed
Nov 9, 2021
This change is indeed independent of `RidgeCV`. This commit adds an explanation on the need for a conditional statement during validation. Co-authored-by: Julien Jerphanion <[email protected]>
Tweak to adopt conventions Co-authored-by: Julien Jerphanion <[email protected]>
ogrisel
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
LGTM once the following comments are addressed.
I think this deserves a changelog entry in doc/whats_new/v1.1.rst in the linear_model section stating that Ridge and ridge_regression now raise consistent error message when passed invalid values for alpha, max_iter and tol.
glemaitre
approved these changes
Nov 22, 2021
jjerphan
approved these changes
Nov 26, 2021
There was a problem hiding this comment.
LGTM once the conflicts with main are solved. Thank you, @ArturoAmorQ!
|
@ArturoAmorQ Could you solve the conflict? We will be able to merge this one. |
Co-authored-by: Julien Jerphanion <[email protected]>
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Dec 1, 2021
Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Solves a part of the Issue #20724 as mentioned in this comment
What does this implement/fix? Explain your changes.
Use the helper function
check_scalarfromsklearn.utilsto validate scalar parameters and making sure to get consistent error types and messages inlinear_model.RidgeAny other comments?
Happy to contribute to the scikit-learn project for the first time!