DOC Ensures that config_context passes numpydoc validation #21426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: majauhar <[email protected]>
|
#DataUmbrella sprint |
adrinjalali
reviewed
Oct 23, 2021
|
I agree with @adrinjalali. We try to limit as much as possible |
…f the function Co-authored-by: majauhar <[email protected]>
glemaitre
reviewed
Oct 23, 2021
…ction signature Co-authored-by: majauhar <[email protected]>
glemaitre
reviewed
Oct 24, 2021
…rd arguments Co-authored-by: majauhar <[email protected]>
glemaitre
approved these changes
Oct 24, 2021
There was a problem hiding this comment.
LGTM. Maybe just a second review on this one.
ping @adrinjalali @jjerphan
ogrisel
reviewed
Oct 24, 2021
jjerphan
reviewed
Oct 25, 2021
There was a problem hiding this comment.
LGTM after changing default values to None as mentioned in this thread: https://github.com/scikit-learn/scikit-learn/pull/21426/files#r735161499
…et_config. Co-authored-by: majauhar <[email protected]>
adrinjalali
reviewed
Oct 25, 2021
Co-authored-by: majauhar <[email protected]>
adrinjalali
approved these changes
Oct 25, 2021
ogrisel
reviewed
Oct 29, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…arn#21426) Co-authored-by: majauhar <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…arn#21426) Co-authored-by: majauhar <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
glemaitre
added a commit
that referenced
this pull request
Dec 25, 2021
Co-authored-by: majauhar <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Any other comments?
This is my and @majauhar first pull request made during #DataUmbrella sprint.