Codestin Search App

Haidar13 · 2021-10-23T19:04:47Z

Reference Issues/PRs

Addresses #21406

What does this implement/fix? Explain your changes.

Moves ValueError checks from _init_ to fit

Any other comments?

#DataUmbrella

glemaitre · 2021-10-23T20:35:59Z

I think that we should add an entry in the changelog since it could have an effect on third-party libraries.

Please add an entry to the change log at doc/whats_new/v1.1.rst. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:. For instance, it should look like:

- |Fix| :class:`smv.SVM` (and add all the other impacted classes) nows validate input parameters in `fit`
  instead of `__init__`.
  :pr:`21436` by :user:`Haidar Almubarak   <Haidar13 >`.

It should in the section:

:mod:`sklearn.svm`

glemaitre

Apart from that everything looks good. We already have the proper test calling fit.

thomasjpfan

Thank you for the PR @Haidar13 !

Haidar13 · 2021-10-24T08:37:58Z

The last update gave coverage issues for the test.

There is test_svm_gamma_error in test_svm.py but the condition and message in the test are not the same as the ones in the codebase.

scikit-learn/sklearn/svm/tests/test_svm.py

Lines 698 to 703 in 6f720c5

    
           def test_svm_gamma_error(Estimator, data): 
        
               X, y = data 
        
               est = Estimator(gamma="auto_deprecated") 
        
               err_msg = "When 'gamma' is a string, it should be either 'scale' or 'auto'" 
        
               with pytest.raises(ValueError, match=err_msg): 
        
                   est.fit(X, y)

Do you want to merge this PR and create another issue/PR for test coverage or put it all in one PR?

glemaitre · 2021-10-24T09:08:17Z

No this is better to cover the missing case in this PR. This is related to the PR itself.

ogrisel

Indeed, please add the missing tests to cover the checks as part of this PR.

Co-authored-by: Guillaume Lemaitre <[email protected]>

Co-authored-by: Olivier Grisel <[email protected]>

Haidar13 · 2021-10-29T19:30:11Z

I just pushed the updated code with the tests added.

Just one comment, flake8 did not catch everything that the linter in the Github action complained about. I saw that one of the actions was using black, I installed black and let it reformat the file then everything went well. what linter is used here?

glemaitre · 2021-10-30T13:55:28Z

We are using flake8 on the diff and black on all files if I recall well.

glemaitre

Still my +1. Maybe @ogrisel or @thomasjpfan want to have a look here during the sprint.

ogrisel

Note: I pushed some commits to resolve the conflict with main. Don't forget to pull before adding new changes.

There are missing periods in the error messages (see below). I am also suggesting to use the !r format to use repr(self.gamma) which is more informative than str(self.gamma) in error messages.

The tests will need to be adjusted accordingly. Once done, +1 for merge on my side.

Haidar13 · 2021-11-04T19:06:03Z

Done, periods added and repr is now used to print the gamma instead of str

jjerphan

LGTM. Thank you, @Haidar13!

…21436) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>

Moving the validation from __init__ to fit for SVM estimators

8a465eb

github-actions Bot added the module:svm label Oct 23, 2021

glemaitre approved these changes Oct 23, 2021

View reviewed changes

Comment thread sklearn/svm/_base.py Outdated

Comment thread sklearn/svm/_base.py Outdated

glemaitre changed the title ~~Moving parameter validation from __init__ to fit for SVM estimators~~ FIX validate parameters in fit in all SVM estimators Oct 23, 2021

thomasjpfan reviewed Oct 23, 2021

View reviewed changes

Comment thread sklearn/svm/_base.py Outdated

Haidar13 added 2 commits October 24, 2021 00:50

Reordring import and adding changlog info for SVM estimators

97c6b96

Reordring import and adding changlog info for SVM estimators

859e01f

glemaitre reviewed Oct 24, 2021

View reviewed changes

Comment thread doc/whats_new/v1.1.rst Outdated

ogrisel reviewed Oct 24, 2021

View reviewed changes

Comment thread sklearn/svm/_base.py

Haidar13 and others added 2 commits October 24, 2021 12:50

Update doc/whats_new/v1.1.rst

0cbcbae

Co-authored-by: Guillaume Lemaitre <[email protected]>

Update sklearn/svm/_base.py add Integral check for gamma value

e5df7a8

Co-authored-by: Olivier Grisel <[email protected]>

reshamas added the Sprint label Oct 24, 2021

Haidar13 added 2 commits October 29, 2021 20:04

Adding test for gamma error messages in the SVM module

3348a39

Adding test for gamma error messages in the SVM module

f261912

glemaitre approved these changes Oct 30, 2021

View reviewed changes

thomasjpfan reviewed Oct 31, 2021

View reviewed changes

Comment thread sklearn/svm/_base.py Outdated

ogrisel added 2 commits November 4, 2021 16:20

Revert bad suggestion from @ogrisel ;)

779cf4e

Merge branch 'main' into estimatorValidation

46752e1

ogrisel approved these changes Nov 4, 2021

View reviewed changes

Comment thread sklearn/svm/_base.py Outdated

Comment thread sklearn/svm/_base.py Outdated

fixing typos

bf5fefa

jjerphan approved these changes Nov 5, 2021

View reviewed changes

jjerphan merged commit 8d3304a into scikit-learn:main Nov 5, 2021

glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Nov 29, 2021

FIX validate parameters in fit in all SVM estimators (scikit-learn#…

ea5a65e

…21436) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>

samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021

FIX validate parameters in fit in all SVM estimators (scikit-learn#…

c8ada9e

…21436) Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>

Uh oh!

Uh oh!

Conversation

Haidar13 commented Oct 23, 2021

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Uh oh!

glemaitre commented Oct 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

glemaitre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thomasjpfan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Haidar13 commented Oct 24, 2021

Uh oh!

glemaitre commented Oct 24, 2021

Uh oh!

Uh oh!

ogrisel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Haidar13 commented Oct 29, 2021

Uh oh!

glemaitre commented Oct 30, 2021

Uh oh!

glemaitre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ogrisel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Haidar13 commented Nov 4, 2021

Uh oh!

jjerphan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

glemaitre commented Oct 23, 2021 •

edited

Loading