-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC Ensures that sklearn.utils.validation.has_fit_parameter passes numpydoc validation #21471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
37cb07e
adding example
reshamas 3d0a3ce
Merge branch 'main' of github.com:scikit-learn/scikit-learn into main
reshamas bcd869e
Merge branch 'main' of github.com:scikit-learn/scikit-learn into main
reshamas 09ee884
Merge branch 'main' of github.com:scikit-learn/scikit-learn into main
reshamas 71ad4e3
Merge branch 'main' of github.com:scikit-learn/scikit-learn into main
reshamas a48493b
Merge branch 'main' of github.com:scikit-learn/scikit-learn into main
reshamas fcf49d8
Merge branch 'main' of github.com:scikit-learn/scikit-learn into main
reshamas 5cb0ed3
Merge branch 'main' of github.com:scikit-learn/scikit-learn into main
reshamas b2d0720
Merge branch 'main' of github.com:scikit-learn/scikit-learn into main
reshamas 42aebe0
Merge branch 'main' of github.com:scikit-learn/scikit-learn into main
reshamas 9bfbdd2
Merge branch 'main' of github.com:scikit-learn/scikit-learn into main
reshamas a1e3a17
fixing formatting
reshamas d8147a2
fix compose.rst
reshamas 808f3e9
Merge branch 'main' of github.com:scikit-learn/scikit-learn into np_v…
reshamas 487fe82
put is_fitted in backticks
reshamas 8bd3854
remove leading whitespace
reshamas fc6f4b5
Merge branch 'np_v_has_fit_parameter' of https://github.com/reshamas/…
reshamas 58c0e70
Merge branch 'main' of github.com:scikit-learn/scikit-learn into np_v…
reshamas e017c2e
Merge branch 'main' of github.com:scikit-learn/scikit-learn into np_v…
reshamas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you changed more than just this function. You might want to uncomment all the functions that you modified to be sure that there is not other problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glemaitre I thought that when I changed this file, it was only related to one function. But, now I see it's all those functions in one file. But, I didn't run the pytest on those other functions, I only fixed putting backticks on the parameters.
Also, sometimes I don't know where the error is (what line number), so I believe what I do is make the change in a function until the error goes away.
I can work on the other 6 functions within
validation, but in separate PRs, because I just ran pytest against the others and there are still errors which need to be fixed separate for each of them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK fine with me. The thing is that you could have delayed the change with the backtick for the other PRs as well. Like this, the scope of the changes is really limited to a single place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will keep that in mind for the future. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid introducing confusing unnecessary merge conflicts with other concurrent PRs by first time contributors also working on #21350, I would rather have PRs only focused on a specific function at a time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reshamas I guess what @ogrisel is asking, is to revert the changes which are not related to the function you're directly addressing in this PR, and to open a separate PR for them, which I agree with, especially if it helps with fewer merge conflicts with other PRs.
Could you elaborate what the output you see is, so that we could maybe help you find the relevant places to fix?