Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Ensures that sklearn.utils.validation.column_or_1d passes numpydoc validation #21519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

reshamas
Copy link
Member

@reshamas reshamas commented Nov 1, 2021

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

NumPy errors + formatting

Any other comments?

Only changed one function this time.

#DataUmbrella sprint

@reshamas
Copy link
Member Author

reshamas commented Nov 1, 2021

@thomasjpfan
Looks like I did not revert those commits from the old PR (#21471).
I created a new branch and saved the changes to the other branch. But, it's not doing what I expected.

@reshamas
Copy link
Member Author

reshamas commented Nov 1, 2021

@thomasjpfan
I think the issue is I accidentally had pushed changes to my main branch. I created a new branch from main to make changes to just one function, but it brought over those changes I had made to the main branch.

@thomasjpfan
Copy link
Member

I think the issue is I accidentally had pushed changes to my main branch. I created a new branch from main to make changes to just one function, but it brought over those changes I had made to the main branch.

  1. To get your local main branch back in sync with upstream/main:
git checkout main
git fetch upstream/main
git reset --hard upstream/main
  1. Since there are no changes to column_or_1d here, I recommend starting over:
git branch -D np_v_column_or_1d
git checkout -b np_v_column_or_1d upstream/main

After updating np_v_column_or_1d force push it to your fork:

git push -u origin -f np_v_column_or_1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants