FIX Don't use setuptools 58.5 which introduces regression #21549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary fix for: pypa/setuptools#2849
ogrisel
reviewed
Nov 4, 2021
|
Unfortunately changing the dependency version in pyproject.toml alone does not work, probably because we do not use build isolation on the CI. I think we also need to change the setuptools setup in the configuration of the CI jobs. |
ogrisel
approved these changes
Nov 4, 2021
|
It seems to work on most builds. Let's wait for the fast tests to complete and merge without waiting for the slow PyPy job. |
adrinjalali
approved these changes
Nov 4, 2021
I propose to be responsible for reverting the commit when the issue is resolved. 🙂 |
|
I am merging now since the PyPy is in the testing part and the install was successful (while it would have broken before). Thanks, @jjerphan Let's track the |
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Nov 5, 2021
…cikit-learn#21549)" This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
ogrisel
pushed a commit
that referenced
this pull request
Nov 5, 2021
…21549)" (#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
…cikit-learn#21549)" (scikit-learn#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…cikit-learn#21549)" (scikit-learn#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…cikit-learn#21549)" (scikit-learn#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
…21549)" (#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
pypa/setuptools#2849
What does this implement/fix? Explain your changes.
This is a temporary fix for: pypa/setuptools#2849