MAINT Revert HOTFIX introduced in #21549 #21560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cikit-learn#21549)" This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
adrinjalali
approved these changes
Nov 5, 2021
ogrisel
approved these changes
Nov 5, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
…cikit-learn#21549)" (scikit-learn#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…cikit-learn#21549)" (scikit-learn#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…cikit-learn#21549)" (scikit-learn#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
…21549)" (#21560) This reverts commit 953d101. The fix for setuptools#21549 has been introduced in 58.5.3. See: pypa/setuptools#2855 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Reverts #21549.
Relates to pypa/setuptools#2855.
What does this implement/fix? Explain your changes.
The fix for pypa/setuptools#2849 has been introduced in setuptools 58.5.3 via pypa/setuptools#2855 (See: pypa/setuptools#2855 (comment)).
This reverts commit 953d101 which introduced a temporary hotfix.