Make algorithm='auto' default to using 'full' instead of 'elkan' - #21735
Merged
Conversation
ogrisel
approved these changes
Nov 22, 2021
ogrisel
left a comment
Member
There was a problem hiding this comment.
Thanks for the quick PR, overall it looks good to me. Just a few comments:
Contributor
Author
|
Thanks for the review @ogrisel , I'll take care of this today. |
Contributor
Author
|
Done |
glemaitre
approved these changes
Nov 25, 2021
glemaitre
left a comment
Member
There was a problem hiding this comment.
LGTM. Only a small nitpick.
Member
|
I merge my small nitpick to go ahead. |
Member
|
Thanks @ageron |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
…cikit-learn#21735) Co-authored-by: Guillaume Lemaitre <[email protected]>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…cikit-learn#21735) Co-authored-by: Guillaume Lemaitre <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #21729
What does this implement/fix? Explain your changes.
In
sklearn.cluster.KMeans, the defaultalgorithm="auto"now uses the full classical EM-style algorithm (as withalgorithm="full") instead of Elkan's algorithm, as the former is often faster in practice.Any other comments?
This does not affect the result of clustering, and the default parameter remains
"auto", so this should only affect performance.