CI Explicitly list out wheel builds in config [cd build gh] #21849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Dec 2, 2021
| # 1 osx wheel (x86_64) | ||
| # 4 linux wheel (i686 + x86_64) * (manylinux1 + manylinux2010) | ||
| # 2 windows wheel (win32 + wind_amd64) | ||
| n_wheels = 7 * n_python_versions |
There was a problem hiding this comment.
While we are at it, could you please improve the error message when n_dist_files != n_wheels to print the observed list of dist_files below?
ogrisel
approved these changes
Dec 2, 2021
|
Merged as this is a net improvement, we can always refine the error message later if needed. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21827 (macos arm64 wheels)
Related to #21232 (Python 3.10 wheels)
This PR does
[cd build gh]build tag to trigger GitHub and to save Travis CI creditCC @adrinjalali @ogrisel