Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added error checks for invalid combination of include_boundaries and min_value/max_value #22074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Added error checks for invalid combination of include_boundaries and min_value/max_value #22074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e8a32b
Added error checks for invalid combination of and
adityarg Dec 25, 2021
acc2eec
Added error checks for invalid combination of boundaries
adityarg Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sklearn/utils/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,6 +1418,15 @@ def check_scalar(
f"Possible values are: {expected_include_boundaries}."
)

if include_boundaries in ("left", "both") and min_val is None:
raise ValueError(
f"Invalid combination of `{include_boundaries}` and `{min_val}`"
)
if include_boundaries in ("right", "both") and max_val is None:
raise ValueError(
f"Invalid combination of `{include_boundaries}` and `{max_val}`"
)

comparison_operator = (
operator.lt if include_boundaries in ("left", "both") else operator.le
)
Expand Down