DOC added intervals for parameters for 4 glm classes #22076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ogrisel Did you want to review this PR as well? It's (relatively) simpler than the other one on SGDClassifier. |
12 tasks
glemaitre
reviewed
Jan 10, 2022
sklearn/linear_model/_glm/glm.py
Outdated
|
|
||
| warm_start : bool, default=False | ||
| If set to ``True``, reuse the solution of the previous call to ``fit`` | ||
| as initialization for ``coef_`` and ``intercept_``. | ||
|
|
||
| verbose : int, default=0 | ||
| For the lbfgs solver set verbose to any positive number for verbosity. | ||
| Values should be in the range `[1, inf)`. |
There was a problem hiding this comment.
Suggested change
| Values should be in the range `[1, inf)`. | |
| Values should be in the range `[0, inf)`. |
sklearn/linear_model/_glm/glm.py
Outdated
|
|
||
| warm_start : bool, default=False | ||
| If set to ``True``, reuse the solution of the previous call to ``fit`` | ||
| as initialization for ``coef_`` and ``intercept_`` . | ||
|
|
||
| verbose : int, default=0 | ||
| For the lbfgs solver set verbose to any positive number for verbosity. | ||
| Values should be in the range `[1, inf)`. |
There was a problem hiding this comment.
Suggested change
| Values should be in the range `[1, inf)`. | |
| Values should be in the range `[0, inf)`. |
|
Reminder to me:
|
glemaitre
reviewed
Jan 10, 2022
sklearn/linear_model/_glm/glm.py
Outdated
| @@ -72,6 +72,7 @@ class GeneralizedLinearRegressor(RegressorMixin, BaseEstimator): | |||
| regularization strength. ``alpha = 0`` is equivalent to unpenalized | |||
| GLMs. In this case, the design matrix `X` must have full column rank | |||
| (no collinearities). | |||
| Values should be in the range `[0.0, inf)`. | |||
There was a problem hiding this comment.
To be in line with #21946
Suggested change
| Values should be in the range `[0.0, inf)`. | |
| Values must be in the range `[0.0, inf)`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #21927 and #21946
What does this implement/fix? Explain your changes.
class GeneralizedLinearRegressor(RegressorMixin, BaseEstimator)class PoissonRegressor(GeneralizedLinearRegressor)class GammaRegressor(GeneralizedLinearRegressor)class TweedieRegressor(GeneralizedLinearRegressor)alpha,max_iter,tolandverboseAny other comments?
#DataUmbrella #postsprint