Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Ensures that manhattan_distances passes numpydoc validation #22139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 10, 2022
Merged

DOC Ensures that manhattan_distances passes numpydoc validation #22139

merged 6 commits into from
Jan 10, 2022

Conversation

Micky774
Copy link
Contributor

@Micky774 Micky774 commented Jan 7, 2022

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Brings the function sklearn.metrics.pairwise.manhattan_distances into numpydoc compliance

Any other comments?

N/A

thomasjpfan
thomasjpfan approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@thomasjpfan
Copy link
Member

There is a merge conflict now, likely due to merging #22140.

thomasjpfan
thomasjpfan approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.metrics.pairwise.manhattan_distances passes numpydoc validation DOC Ensures that manhattan_distances passes numpydoc validation Jan 10, 2022
@thomasjpfan thomasjpfan merged commit ff09c8a into scikit-learn:main Jan 10, 2022
@thomasjpfan thomasjpfan mentioned this pull request Jan 17, 2022
Closed
@Micky774 Micky774 deleted the numpydoc_manhatten_distances branch February 22, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
Documentation module:metrics No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Micky774 @thomasjpfan @jjerphan