ENH force_all_finite=False before calling _raw_predict - #22159
Merged
jjerphan merged 7 commits intoJan 13, 2022
Conversation
thomasjpfan
approved these changes
Jan 9, 2022
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
Minor comments, otherwise LGTM
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
jjerphan
approved these changes
Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Suggested by @thomasjpfan in PR #22089.
Link to the comment
What does this implement/fix? Explain your changes.
method
fitof classensemble.BaseGradientBoostingnowcalls func
check_arraywith parameterforce_all_finite=Falsefor noninitial warm-start runs as it has already been checked before.