Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Ensures that compute_optics_graph passes numpydoc validation #22205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2022
Merged

DOC Ensures that compute_optics_graph passes numpydoc validation #22205

merged 2 commits into from
Jan 21, 2022

Conversation

ayanbag
Copy link
Contributor

@ayanbag ayanbag commented Jan 13, 2022

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Removed an unnecessary period after parameter "X" type and added a missing period after parameter "X" description.

Any other comments?

jmloyola
jmloyola reviewed Jan 14, 2022
View reviewed changes
Copy link
Member

@jmloyola jmloyola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ayanbag 🤓

I left one suggestion. It is something that was already in the code-base, but since we're fixing the docs, it would be great to do it now ^^.

ogrisel
ogrisel approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 once @jmloyola's suggestion is accepted.

@ayanbag @jmloyola
Update sklearn/cluster/_optics.py
24c77a4 
Co-authored-by: Juan Martin Loyola <[email protected]>
@thomasjpfan thomasjpfan mentioned this pull request Jan 17, 2022
Closed
jjerphan
jjerphan approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jjerphan jjerphan merged commit 3db677f into scikit-learn:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmloyola jmloyola jmloyola left review comments

@ogrisel ogrisel ogrisel approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
Documentation module:cluster No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ayanbag @ogrisel @jmloyola @jjerphan @thomasjpfan