ENH Better error message for check_scalar - #22218
Merged
glemaitre merged 13 commits intoFeb 11, 2022
Merged
Conversation
Member
|
It might be better understood to say integer and floating instead of |
Member
Author
Is the only reason we use |
Member
|
I think yes. |
Member
Author
|
I updated this PR to use |
jjerphan
approved these changes
Jan 26, 2022
lorentzenchr
approved these changes
Feb 9, 2022
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
Co-authored-by: Guillaume Lemaitre <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up to #20724
What does this implement/fix? Explain your changes.
Adjusts the error message to only include the class name and not the
<class _>part of the str representationCC @glemaitre