Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST Add some tests parametrization for test_neighbors #22281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 24, 2022
Merged

TST Add some tests parametrization for test_neighbors #22281

merged 6 commits into from
Jan 24, 2022

Conversation

jjerphan
Copy link
Member

Reference Issues/PRs

Extracted from #22214.

What does this implement/fix? Explain your changes.

Add more tests parametrization for neighbors based interfaces.

Any other comments?

@jjerphan jjerphan mentioned this pull request Jan 24, 2022
Closed
ogrisel
ogrisel reviewed Jan 24, 2022
View reviewed changes
jjerphan
jjerphan commented Jan 24, 2022
View reviewed changes
ogrisel
ogrisel reviewed Jan 24, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test refactoring. Here are some feedback to speed-up the tests and try to increase the coverage for more metrics and expected exceptions in test_neighbors_metrics.

ogrisel
ogrisel reviewed Jan 24, 2022
View reviewed changes
sklearn/neighbors/tests/test_neighbors.py
neighbors.VALID_METRICS["brute"]
)
- set(["pyfunc", *BOOL_METRICS])
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, both explicit and easy to maintain!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not whether you are serious or just joking.
Honestly, if one can suggest an eased definition, I would appreciate it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a joke. I find it explicit this way which is good.

ogrisel
ogrisel approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jjerphan!

Edit: assuming CI with the new code will be green :)

thomasjpfan
thomasjpfan approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 104dede into scikit-learn:main Jan 24, 2022
@jjerphan jjerphan deleted the test-neighbors-add-parametrisation branch January 24, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:neighbors No Changelog Needed Waiting for Reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjerphan @ogrisel @thomasjpfan