Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT Follow-up on a fix for criterion="poisson" in decision trees #22306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Jan 26, 2022

Follow-up PR on #22191.

  • fixes the ordering of the changelog;
  • make sklearn.ensemble.test.test_forest.test_tree robust to a change in the random seed (I tried all seed in the [0-99] range).

@ogrisel
Copy link
Member Author

ogrisel commented Jan 26, 2022

CI is expected to fail because of #22302.

@ogrisel ogrisel added the Quick Review For PRs that are quick to review label Jan 26, 2022
@ogrisel ogrisel added this to the 1.1 milestone Jan 26, 2022
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glemaitre glemaitre changed the title Follow-up on a fix for criterion="poisson" in decision trees MAINT Follow-up on a fix for criterion="poisson" in decision trees Jan 26, 2022
@ogrisel ogrisel merged commit 26e1930 into scikit-learn:main Jan 26, 2022
@ogrisel ogrisel deleted the poisson-trees branch January 26, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation module:tree No Changelog Needed Quick Review For PRs that are quick to review workflow Development workflow changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants