FIX skip tests when estimator has non_deterministic tag - #22318
Merged
thomasjpfan merged 7 commits intoFeb 15, 2022
Conversation
Member
|
Thanks for the PR. This also needs a regression test to test the change. |
adrinjalali
reviewed
Jan 29, 2022
adrinjalali
approved these changes
Jan 31, 2022
…nto fix/skip-test-non-deterministic
thomasjpfan
approved these changes
Feb 15, 2022
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR @MaxwellLZH !
LGTM
thomasjpfan
approved these changes
Feb 15, 2022
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
Please add an entry to the change log at doc/whats_new/v1.1.rst with tag |Fix|. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:.
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This is a fix to issue #22313 , where estimators with non_deterministic tag set to
Truewill skip bothcheck_methods_sample_order_invarianceandcheck_methods_subset_invariancetests