Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MRG] DOC Update documentation of voting estimators w/ ranges #22353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

genvalen
Copy link
Contributor

@genvalen genvalen commented Feb 1, 2022

Reference Issues/PRs

Related to #22204

What does this implement/fix? Explain your changes.

Update VotingClassifier and VotingRegressor documentation to include the expected range of the scalar parameters.

Any other comments?

For verbose, do we enforce only bool inputs? I forgot the requirement, so I included the accepted int range as well.

@genvalen
Copy link
Contributor Author

genvalen commented Feb 2, 2022

Whoops, I missed a double line break. Sorry about that! Hopefully this is good now.

@ArturoAmorQ
Copy link
Member

Thanks for your contribution @genvalen. I think that the word bool in the description of the parameters you mention in this PR already implies that they are Boolean data type, a form of data with only two possible values (in this case True or False). It is therefore not expected (and should not be valid either) to pass any other argument other than those.

@thomasjpfan
Copy link
Member

During community office hours, we decided to close this issue as there are only two possible values for bools and do not need to explicitly documented.

@thomasjpfan thomasjpfan closed this Feb 7, 2022
@genvalen genvalen deleted the voting_estimators_add_param_range_to_docs branch February 23, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants