Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Ensures that load_digits passes numpydoc validation #22392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

DennisOsei
Copy link
Contributor

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

  1. Removed sklearn.datasets._base.load_digits from tests/test_docstrings.
  2. Added description to (data, target)
  3. Moved link of UCI ML hand-written digits datasets to below the datasets table.

Any other comments?

*My previous PR( load_breast_cancer) has been successfully merged but the "Functions to Update" is still showing the PR that was closed.

@ArturoAmorQ
Copy link
Member

Thanks for tackling this one too, @DennisOsei ! It seems that your local repo is not up-to date. Could you please solve the conflict by merging main into your branch? Let me know if you need help doing that.

@DennisOsei
Copy link
Contributor Author

@ArturoAmorQ can you be more specific. Do you mean my main branch into numpydoc-validation? Also I would appreciate steps for what your trying to imply. Thanks.

@ArturoAmorQ
Copy link
Member

Do you mean my main branch into numpydoc-validation?

I meant the main branch from the scikit-learn repo into your numpydoc-validation branch. If you are using a terminal, try running

git pull upstream main

inside your branch. Here upstream is the alias for the remote (which you can verify by taping git remote -v) and main is the branch in the remote.

This will usually pop a text editor where you have to assign a message to the commit or you will be asked to solve an eventual conflict (this should not be the case here). Then push again this new commit.

Both in your main branch and inside any branches that were created a long time ago, it is a good practice to run a git pull upstream main to keep your local updated.

If you are not using the command line, maybe you can check this post in stackoverflow. Just keep in mind that the main branch of scikit-learn is named main instead of master, as mentioned in such post.

Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @DennisOsei !

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.datasets._base.load_digits passes numpydoc validation DOC Ensures that load_digits passes numpydoc validation Feb 9, 2022
@thomasjpfan thomasjpfan merged commit 39c341a into scikit-learn:main Feb 9, 2022
ilivans pushed a commit to ilivans/scikit-learn that referenced this pull request Feb 10, 2022
@DennisOsei DennisOsei deleted the numpydoc-validation branch February 14, 2022 22:44
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants