-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC Ensures that load_digits passes numpydoc validation #22392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for tackling this one too, @DennisOsei ! It seems that your local repo is not up-to date. Could you please solve the conflict by merging |
@ArturoAmorQ can you be more specific. Do you mean my main branch into numpydoc-validation? Also I would appreciate steps for what your trying to imply. Thanks. |
I meant the
inside your branch. Here This will usually pop a text editor where you have to assign a message to the commit or you will be asked to solve an eventual conflict (this should not be the case here). Then push again this new commit. Both in your If you are not using the command line, maybe you can check this post in stackoverflow. Just keep in mind that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @DennisOsei !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Any other comments?
*My previous PR( load_breast_cancer) has been successfully merged but the "Functions to Update" is still showing the PR that was closed.