DOC: use notebook-style for plot_stock_market.py - #22461
Conversation
|
For this example, it would be as well nice to move the section and discussion of the top summary next to the cell of code that implements what is written in the discussion. In this way, the example will really feel like a real notebook and will be easier to read. |
|
I have done the changes as you said @glemaitre . Have a look. |
glemaitre
left a comment
There was a problem hiding this comment.
This is improving the example greatly. Only a couple of things to address. I will check a bit more in detail why the GraphicalLassoCV is raising a warning.
…nto example_update
…nto example_update
|
@glemaitre can you have a look and let me know an update on this PR. |
|
I pushed a commit into your branch tackling #22461 (comment). I think this should get rid of the warning. About your error, if you want to build from source you should look at: https://scikit-learn.org/stable/developers/advanced_installation.html#building-from-source |
|
Looks good, merging, thanks! |
Co-authored-by: Loïc Estève <[email protected]>
Co-authored-by: Loïc Estève <[email protected]>
Reference Issues/PRs
Updates
examples/applications/plot_stock_market.pyFor Issue Fix notebook-style examples #22406
What does this implement/fix? Explain your changes.
Updated the example plot_stock_market.py to notebook style. Also fixed minor wordings as seemed fit.
Any other comments?