Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Fix MDS images in user guide #22465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Conversation

Micky774
Copy link
Contributor

@Micky774 Micky774 commented Feb 12, 2022

Reference Issues/PRs
Fixes #22061
Resolves #22165

What does this implement/fix? Explain your changes.
In order to fix Sphinx gallery rendering, this PR plots the generated figures individually rather than through one composite subplot.

Any other comments?

@Micky774
Copy link
Contributor Author

@thomasjpfan @glemaitre

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example itself does not look as nice, but I think fixing the images in user guide is more important.

Minor comment otherwise LGTM

@thomasjpfan thomasjpfan changed the title [DOC] Fix MDS images DOC Fix MDS images in user guide Feb 13, 2022
@cmarmo cmarmo added this to the 1.1 milestone Feb 14, 2022
@glemaitre glemaitre merged commit 38173e9 into scikit-learn:main Feb 14, 2022
@glemaitre
Copy link
Member

Thanks @Micky774 I will close the remaining stalled PRs.

thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
@Micky774 Micky774 deleted the mds_rendering branch May 19, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken image in MDS user guide documentation
4 participants