Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Ensures that load_linnerud passes numpydoc validation #22484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 27, 2022
Merged

DOC Ensures that load_linnerud passes numpydoc validation #22484

merged 4 commits into from
Feb 27, 2022

Conversation

DennisOsei
Copy link
Contributor

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

  1. Removed sklearn.datasets._base.load_linnerud from function_docstring_ignore_list.
  2. Added description to (data, target).

Any other comments?

glemaitre
glemaitre reviewed Feb 16, 2022
View reviewed changes
@DennisOsei @glemaitre
Edited (data,target) description
62cbf4e 
Co-authored-by: Guillaume Lemaitre <[email protected]>
@DennisOsei DennisOsei changed the title DOC Ensures that sklearn.datasets._base.load_linnerud passes numpydoc validation DOC Ensures that linnerud passes numpydoc validation Feb 19, 2022
@DennisOsei
Copy link
Contributor Author

@glemaitre this PR is still open. Hopefully you haven't forgotten about it 😄

thomasjpfan
thomasjpfan reviewed Feb 26, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @DennisOsei !

@DennisOsei
Copy link
Contributor Author

Thanks @thomasjpfan, commited the suggested changes.

thomasjpfan
thomasjpfan approved these changes Feb 26, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment otherwise LGTM

@DennisOsei
Copy link
Contributor Author

@thomasjpfan updated.

@thomasjpfan thomasjpfan merged commit bdd5a9e into scikit-learn:main Feb 27, 2022
thomasjpfan added a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
@DennisOsei @glemaitre @thomasjpfan
DOC Ensures that linnerud passes numpydoc validation (scikit-learn#22484
3d6d61d 
)

Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
@thomasjpfan thomasjpfan changed the title DOC Ensures that linnerud passes numpydoc validation DOC Ensures that load_linnerud passes numpydoc validation Mar 12, 2022
@thomasjpfan thomasjpfan mentioned this pull request Mar 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation module:datasets No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DennisOsei @thomasjpfan @glemaitre