ENH Adds file extension selection to load_files - #22498
Merged
thomasjpfan merged 30 commits intoFeb 17, 2022
Merged
Conversation
…nto datasets_select_load_files_extensions
looks good lets see what the ci says
Co-authored-by: Thomas J. Fan <[email protected]>
…b.com/Micky774/scikit-learn into datasets_select_load_files_extensions
thomasjpfan
reviewed
Feb 16, 2022
thomasjpfan
reviewed
Feb 16, 2022
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
Thanks for the update. A small nit regarding creating the set multiple times.
thomasjpfan
approved these changes
Feb 17, 2022
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
Minor comment otherwise LGTM
Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Tony <[email protected]> Co-authored-by: Kazim <[email protected]> Co-authored-by: Tony Attalla <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Continues PR #19747
Resolves #19747
Fixes #19269
What does this implement/fix? Explain your changes.
PR #19747: Adds a new parameter
allowed_extensionswhich allows users to specify extensions to load when using load_files.This PR: Addresses remaining review comment and slightly modifies selection logic.
Any other comments?