ENH Verbosity for OneVsRestClassifier - #22508
Merged
ogrisel merged 6 commits intoFeb 18, 2022
Merged
Conversation
thomasjpfan
reviewed
Feb 16, 2022
Member
There was a problem hiding this comment.
Thank you for the PR!
Please add an entry to the change log at doc/whats_new/v1.1.rst with tag |Enhancement|. Like the other entries there, please reference this pull request with :pr: and credit yourself (and other contributors if applicable) with :user:.
| The verbosity level, if non zero, progress messages are printed. | ||
| Below 50, the output is sent to stderr. Otherwise, the output is sent | ||
| to stdout. The frequency of the messages increases with the verbosity | ||
| level, reporting all iterations at 10. See joblib.Parallel for more |
Member
There was a problem hiding this comment.
We can link directly out to the API docs for Parallel:
Suggested change
| level, reporting all iterations at 10. See joblib.Parallel for more | |
| level, reporting all iterations at 10. See :class:`joblib.Parallel` for more |
| multilabel classification. | ||
| sklearn.preprocessing.MultiLabelBinarizer : Transform iterable of iterables | ||
| to binary indicator matrix. | ||
| joblib.Parallel : Class used for parallel training. |
Member
There was a problem hiding this comment.
We can link in the verbose docstring itself.
Suggested change
| joblib.Parallel : Class used for parallel training. |
thomasjpfan
approved these changes
Feb 16, 2022
thomasjpfan
left a comment
Member
There was a problem hiding this comment.
Small commit, otherwise LGTM.
I think it's okay to not test for the output, since we are directly passing parameter directly to Parallel.
Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
Co-authored-by: Thomas J. Fan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #22441
What does this implement/fix? Explain your changes.
Adds a verbose parameter to
sklearn.multiclass.OneVsRestClassifierso progress can be seen while the model is fitting.Any other comments?
I'm not familiar with the best way to link to external libraries. I mention
joblib.Parallelin documentation but I'm not sure if there's a better way to directly link to it using Sphinx. LMK if there's a better way to do this!